mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 05:48:40 +00:00
clk: axi-clkgen: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-7-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
This commit is contained in:
parent
04d19184d2
commit
778dc8bb1d
1 changed files with 2 additions and 4 deletions
|
@ -557,11 +557,9 @@ static int axi_clkgen_probe(struct platform_device *pdev)
|
|||
&axi_clkgen->clk_hw);
|
||||
}
|
||||
|
||||
static int axi_clkgen_remove(struct platform_device *pdev)
|
||||
static void axi_clkgen_remove(struct platform_device *pdev)
|
||||
{
|
||||
of_clk_del_provider(pdev->dev.of_node);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id axi_clkgen_ids[] = {
|
||||
|
@ -583,7 +581,7 @@ static struct platform_driver axi_clkgen_driver = {
|
|||
.of_match_table = axi_clkgen_ids,
|
||||
},
|
||||
.probe = axi_clkgen_probe,
|
||||
.remove = axi_clkgen_remove,
|
||||
.remove_new = axi_clkgen_remove,
|
||||
};
|
||||
module_platform_driver(axi_clkgen_driver);
|
||||
|
||||
|
|
Loading…
Reference in a new issue