mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-21 00:10:09 +00:00
Code Issues Releases Wiki Activity

gpio: gpio-mxc: gpio_set_wake_irq() use proper return values

Browse source 
Errors from enable_irq_wake() in gpio_set_wake_irq() were silently ignored.
Thus led to the problem that gpio_set_wake_irq() always returned
successfully, even if enable_irq_wake() returned an error.

Signed-off-by: Philipp Rosenberger <p.rosenberger@linutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Philipp Rosenberger 2017-07-12 10:36:40 +02:00 committed by Linus Walleij
parent dbd1dad2ab
commit 77a4d75719
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/gpio/gpio-mxc.c
View file

@ -324,20 +324,21 @@ static int gpio_set_wake_irq(struct irq_data *d, u32 enable)
struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d);
struct mxc_gpio_port *port = gc->private;
u32 gpio_idx = d->hwirq;
int ret;
if (enable) {
if (port->irq_high && (gpio_idx >= 16))
enable_irq_wake(port->irq_high);
ret = enable_irq_wake(port->irq_high);
else
enable_irq_wake(port->irq);
ret = enable_irq_wake(port->irq);
} else {
if (port->irq_high && (gpio_idx >= 16))
disable_irq_wake(port->irq_high);
ret = disable_irq_wake(port->irq_high);
else
disable_irq_wake(port->irq);
ret = disable_irq_wake(port->irq);
}
return 0;
return ret;
}
static int mxc_gpio_init_gc(struct mxc_gpio_port *port, int irq_base)