mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
ASoC: sirf: Fix potential NULL pointer dereference
commitae1c696a48
upstream. There is a potential execution path in which function platform_get_resource() returns NULL. If this happens, we will end up having a NULL pointer dereference. Fix this by replacing devm_ioremap with devm_ioremap_resource, which has the NULL check and the memory region request. This code was detected with the help of Coccinelle. Cc: stable@vger.kernel.org Fixes:2bd8d1d5cf
("ASoC: sirf: Add audio usp interface driver") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2ef691428e
commit
7806d2ef49
1 changed files with 3 additions and 4 deletions
|
@ -370,10 +370,9 @@ static int sirf_usp_pcm_probe(struct platform_device *pdev)
|
|||
platform_set_drvdata(pdev, usp);
|
||||
|
||||
mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
||||
base = devm_ioremap(&pdev->dev, mem_res->start,
|
||||
resource_size(mem_res));
|
||||
if (base == NULL)
|
||||
return -ENOMEM;
|
||||
base = devm_ioremap_resource(&pdev->dev, mem_res);
|
||||
if (IS_ERR(base))
|
||||
return PTR_ERR(base);
|
||||
usp->regmap = devm_regmap_init_mmio(&pdev->dev, base,
|
||||
&sirf_usp_regmap_config);
|
||||
if (IS_ERR(usp->regmap))
|
||||
|
|
Loading…
Reference in a new issue