mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 13:55:32 +00:00
ASoC: mxs: Fix error handling in mxs_sgtl5000_probe
[ Upstream commit6ae0a4d8fe
] This function only calls of_node_put() in the regular path. And it will cause refcount leak in error paths. For example, when codec_np is NULL, saif_np[0] and saif_np[1] are not NULL, it will cause leaks. of_node_put() will check if the node pointer is NULL, so we can call it directly to release the refcount of regular pointers. Fixes:e968194b45
("ASoC: mxs: add device tree support for mxs-sgtl5000") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220308020146.26496-1-linmq006@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
e49f0cedf1
commit
790d2628e3
1 changed files with 3 additions and 0 deletions
|
@ -112,6 +112,9 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev)
|
|||
codec_np = of_parse_phandle(np, "audio-codec", 0);
|
||||
if (!saif_np[0] || !saif_np[1] || !codec_np) {
|
||||
dev_err(&pdev->dev, "phandle missing or invalid\n");
|
||||
of_node_put(codec_np);
|
||||
of_node_put(saif_np[0]);
|
||||
of_node_put(saif_np[1]);
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue