mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
btrfs: cleanup duplicate return value in insert_inline_extent
The pattern when err is used for function exit and ret is used for return values of callees is not used here. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
6165572c11
commit
79b4f4c605
1 changed files with 2 additions and 6 deletions
|
@ -177,7 +177,6 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,
|
||||||
char *kaddr;
|
char *kaddr;
|
||||||
unsigned long ptr;
|
unsigned long ptr;
|
||||||
struct btrfs_file_extent_item *ei;
|
struct btrfs_file_extent_item *ei;
|
||||||
int err = 0;
|
|
||||||
int ret;
|
int ret;
|
||||||
size_t cur_size = size;
|
size_t cur_size = size;
|
||||||
unsigned long offset;
|
unsigned long offset;
|
||||||
|
@ -199,10 +198,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,
|
||||||
path->leave_spinning = 1;
|
path->leave_spinning = 1;
|
||||||
ret = btrfs_insert_empty_item(trans, root, path, &key,
|
ret = btrfs_insert_empty_item(trans, root, path, &key,
|
||||||
datasize);
|
datasize);
|
||||||
if (ret) {
|
if (ret)
|
||||||
err = ret;
|
|
||||||
goto fail;
|
goto fail;
|
||||||
}
|
|
||||||
}
|
}
|
||||||
leaf = path->nodes[0];
|
leaf = path->nodes[0];
|
||||||
ei = btrfs_item_ptr(leaf, path->slots[0],
|
ei = btrfs_item_ptr(leaf, path->slots[0],
|
||||||
|
@ -257,9 +254,8 @@ static int insert_inline_extent(struct btrfs_trans_handle *trans,
|
||||||
BTRFS_I(inode)->disk_i_size = inode->i_size;
|
BTRFS_I(inode)->disk_i_size = inode->i_size;
|
||||||
ret = btrfs_update_inode(trans, root, inode);
|
ret = btrfs_update_inode(trans, root, inode);
|
||||||
|
|
||||||
return ret;
|
|
||||||
fail:
|
fail:
|
||||||
return err;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue