mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
V4L/DVB: drivers/media/video/zoran: Use kmemdup
Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression from,to,size,flag; statement S; @@ - to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || ...) S - memcpy(to, from, size); // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
cd3172d7da
commit
7a12f4b50d
1 changed files with 2 additions and 3 deletions
|
@ -107,15 +107,14 @@ videocodec_attach (struct videocodec_master *master)
|
||||||
if (!try_module_get(h->codec->owner))
|
if (!try_module_get(h->codec->owner))
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
codec =
|
codec = kmemdup(h->codec, sizeof(struct videocodec),
|
||||||
kmalloc(sizeof(struct videocodec), GFP_KERNEL);
|
GFP_KERNEL);
|
||||||
if (!codec) {
|
if (!codec) {
|
||||||
dprintk(1,
|
dprintk(1,
|
||||||
KERN_ERR
|
KERN_ERR
|
||||||
"videocodec_attach: no mem\n");
|
"videocodec_attach: no mem\n");
|
||||||
goto out_module_put;
|
goto out_module_put;
|
||||||
}
|
}
|
||||||
memcpy(codec, h->codec, sizeof(struct videocodec));
|
|
||||||
|
|
||||||
snprintf(codec->name, sizeof(codec->name),
|
snprintf(codec->name, sizeof(codec->name),
|
||||||
"%s[%d]", codec->name, h->attached);
|
"%s[%d]", codec->name, h->attached);
|
||||||
|
|
Loading…
Reference in a new issue