mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
mtd: parsers: Fix potential memory leak in mtd_parser_tplink_safeloader_parse()
The parts needs to be freed with all its elements, otherwise it will be
leaked.
Fixes: 00a3588084
("mtd: parsers: add TP-Link SafeLoader partitions table parser")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20221208113620.78855-1-yuancan@huawei.com
This commit is contained in:
parent
88603b6dc4
commit
7adde5ac25
1 changed files with 3 additions and 1 deletions
|
@ -91,7 +91,7 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd,
|
|||
buf = mtd_parser_tplink_safeloader_read_table(mtd);
|
||||
if (!buf) {
|
||||
err = -ENOENT;
|
||||
goto err_out;
|
||||
goto err_free_parts;
|
||||
}
|
||||
|
||||
for (idx = 0, offset = TPLINK_SAFELOADER_DATA_OFFSET;
|
||||
|
@ -118,6 +118,8 @@ static int mtd_parser_tplink_safeloader_parse(struct mtd_info *mtd,
|
|||
err_free:
|
||||
for (idx -= 1; idx >= 0; idx--)
|
||||
kfree(parts[idx].name);
|
||||
err_free_parts:
|
||||
kfree(parts);
|
||||
err_out:
|
||||
return err;
|
||||
};
|
||||
|
|
Loading…
Reference in a new issue