mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
ovl: perform vfs_getxattr() with mounter creds
[ Upstream commit 554677b972
]
The vfs_getxattr() in ovl_xattr_set() is used to check whether an xattr
exist on a lower layer file that is to be removed. If the xattr does not
exist, then no need to copy up the file.
This call of vfs_getxattr() wasn't wrapped in credential override, and this
is probably okay. But for consitency wrap this instance as well.
Reported-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
a9313a5cac
commit
7b6887b4d0
1 changed files with 2 additions and 0 deletions
|
@ -216,7 +216,9 @@ int ovl_xattr_set(struct dentry *dentry, struct inode *inode, const char *name,
|
||||||
goto out;
|
goto out;
|
||||||
|
|
||||||
if (!value && !upperdentry) {
|
if (!value && !upperdentry) {
|
||||||
|
old_cred = ovl_override_creds(dentry->d_sb);
|
||||||
err = vfs_getxattr(realdentry, name, NULL, 0);
|
err = vfs_getxattr(realdentry, name, NULL, 0);
|
||||||
|
revert_creds(old_cred);
|
||||||
if (err < 0)
|
if (err < 0)
|
||||||
goto out_drop_write;
|
goto out_drop_write;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue