mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
backlight: lm3639: Unconditionally call led_classdev_unregister
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.
drivers/video/backlight/lm3639_bl.c:403:14: warning: address of
'pchip->cdev_torch' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pchip->cdev_torch)
~~ ~~~~~~~^~~~~~~~~~
drivers/video/backlight/lm3639_bl.c:405:14: warning: address of
'pchip->cdev_flash' will always evaluate to 'true'
[-Wpointer-bool-conversion]
if (&pchip->cdev_flash)
~~ ~~~~~~~^~~~~~~~~~
2 warnings generated.
These statements have been present since 2012, introduced by
commit 0f59858d51
("backlight: add new lm3639 backlight
driver"). Given that they have been called unconditionally since
then presumably without any issues, removing the always true if
statements to fix the warnings without any real world changes.
Link: https://github.com/ClangBuiltLinux/linux/issues/119
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
parent
e6bcca0890
commit
7cea645ae9
1 changed files with 2 additions and 4 deletions
|
@ -400,10 +400,8 @@ static int lm3639_remove(struct i2c_client *client)
|
|||
|
||||
regmap_write(pchip->regmap, REG_ENABLE, 0x00);
|
||||
|
||||
if (&pchip->cdev_torch)
|
||||
led_classdev_unregister(&pchip->cdev_torch);
|
||||
if (&pchip->cdev_flash)
|
||||
led_classdev_unregister(&pchip->cdev_flash);
|
||||
led_classdev_unregister(&pchip->cdev_torch);
|
||||
led_classdev_unregister(&pchip->cdev_flash);
|
||||
if (pchip->bled)
|
||||
device_remove_file(&(pchip->bled->dev), &dev_attr_bled_mode);
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue