mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
pwm: tegra: Don't modify HW state in .remove callback
[ Upstream commit 86f7fa71cd
]
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.
So drop the hardware modification from the .remove() callback.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
f8ba40611b
commit
7d06675215
1 changed files with 0 additions and 13 deletions
|
@ -232,7 +232,6 @@ static int tegra_pwm_probe(struct platform_device *pdev)
|
|||
static int tegra_pwm_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
|
||||
unsigned int i;
|
||||
int err;
|
||||
|
||||
if (WARN_ON(!pc))
|
||||
|
@ -242,18 +241,6 @@ static int tegra_pwm_remove(struct platform_device *pdev)
|
|||
if (err < 0)
|
||||
return err;
|
||||
|
||||
for (i = 0; i < pc->chip.npwm; i++) {
|
||||
struct pwm_device *pwm = &pc->chip.pwms[i];
|
||||
|
||||
if (!pwm_is_enabled(pwm))
|
||||
if (clk_prepare_enable(pc->clk) < 0)
|
||||
continue;
|
||||
|
||||
pwm_writel(pc, i, 0);
|
||||
|
||||
clk_disable_unprepare(pc->clk);
|
||||
}
|
||||
|
||||
reset_control_assert(pc->rst);
|
||||
clk_disable_unprepare(pc->clk);
|
||||
|
||||
|
|
Loading…
Reference in a new issue