mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
rtc: ds1553: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because then userspace is not able to react on the information. Also, it doesn't make sense to return epoch because it is already the default time. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
parent
1c90d9f1c8
commit
7d1bd37ff0
1 changed files with 0 additions and 4 deletions
|
@ -127,10 +127,6 @@ static int ds1553_rtc_read_time(struct device *dev, struct rtc_time *tm)
|
|||
/* year is 1900 + tm->tm_year */
|
||||
tm->tm_year = bcd2bin(year) + bcd2bin(century) * 100 - 1900;
|
||||
|
||||
if (rtc_valid_tm(tm) < 0) {
|
||||
dev_err(dev, "retrieved date/time is not valid.\n");
|
||||
rtc_time_to_tm(0, tm);
|
||||
}
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue