mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

gpio: tps65219: don't use CONFIG_DEBUG_GPIO 

CONFIG_DEBUG_GPIO should only be used to enable debug log messages and
for core GPIOLIB debugging. Don't use it to control the execution of
potentially buggy code. Just put it under an always-false #if.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Bartosz Golaszewski 2023-12-21 19:57:02 +01:00
parent 20bddcb40b
commit 7dd1871e50
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/gpio/gpio-tps65219.c
View File

@ -96,16 +96,16 @@ static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned int off
* Below can be used for test purpose only.
*/
if (IS_ENABLED(CONFIG_DEBUG_GPIO)) {
int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
TPS65219_GPIO0_DIR_MASK, direction);
if (ret) {
dev_err(dev,
"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
direction, offset);
return ret;
}
#if 0
int ret = regmap_update_bits(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG,
TPS65219_GPIO0_DIR_MASK, direction);
if (ret) {
dev_err(dev,
"GPIO DEBUG enabled: Fail to change direction to %u for GPIO%d.\n",
direction, offset);
return ret;
}
#endif
dev_err(dev,
"GPIO%d direction set by NVM, change to %u failed, not allowed by specification\n",