mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 17:30:02 +00:00
net/l2tp: Fix reference count leak in l2tp_udp_recv_core
commit9b6ff7eb66
upstream. The reference count leak issue may take place in an error handling path. If both conditions of tunnel->version == L2TP_HDR_VER_3 and the return value of l2tp_v3_ensure_opt_in_linear is nonzero, the function would directly jump to label invalid, without decrementing the reference count of the l2tp_session object session increased earlier by l2tp_tunnel_get_session(). This may result in refcount leaks. Fix this issue by decrease the reference count before jumping to the label invalid. Fixes:4522a70db7
("l2tp: fix reading optional fields of L2TPv3") Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn> Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn> Signed-off-by: Xin Tan <tanxin.ctf@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a1bb3c064b
commit
7e13a70dc7
1 changed files with 3 additions and 1 deletions
|
@ -994,8 +994,10 @@ static int l2tp_udp_recv_core(struct l2tp_tunnel *tunnel, struct sk_buff *skb,
|
|||
}
|
||||
|
||||
if (tunnel->version == L2TP_HDR_VER_3 &&
|
||||
l2tp_v3_ensure_opt_in_linear(session, skb, &ptr, &optr))
|
||||
l2tp_v3_ensure_opt_in_linear(session, skb, &ptr, &optr)) {
|
||||
l2tp_session_dec_refcount(session);
|
||||
goto error;
|
||||
}
|
||||
|
||||
l2tp_recv_common(session, skb, ptr, optr, hdrflags, length, payload_hook);
|
||||
l2tp_session_dec_refcount(session);
|
||||
|
|
Loading…
Reference in a new issue