mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
HID: alps: Fix memory leak
A kfree(readbuf) call was missed if hid_hw_raw_request() fails, fix it. Also avoid mixing direct return with goto in the error paths. Signed-off-by: Axel Lin <axel.lin@ingics.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
parent
b490a8537d
commit
7ee2eaa364
1 changed files with 3 additions and 2 deletions
|
@ -139,8 +139,8 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address,
|
|||
if (read_flag) {
|
||||
readbuf = kzalloc(U1_FEATURE_REPORT_LEN, GFP_KERNEL);
|
||||
if (!readbuf) {
|
||||
kfree(input);
|
||||
return -ENOMEM;
|
||||
ret = -ENOMEM;
|
||||
goto exit;
|
||||
}
|
||||
|
||||
ret = hid_hw_raw_request(hdev, U1_FEATURE_REPORT_ID, readbuf,
|
||||
|
@ -149,6 +149,7 @@ static int u1_read_write_register(struct hid_device *hdev, u32 address,
|
|||
|
||||
if (ret < 0) {
|
||||
dev_err(&hdev->dev, "failed read register (%d)\n", ret);
|
||||
kfree(readbuf);
|
||||
goto exit;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue