mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
[media] tuners/tda18271: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
03c420010f
commit
7f05b24536
1 changed files with 2 additions and 4 deletions
|
@ -1290,13 +1290,11 @@ int tda18271_assign_map_layout(struct dvb_frontend *fe)
|
|||
switch (priv->id) {
|
||||
case TDA18271HDC1:
|
||||
priv->maps = &tda18271c1_map_layout;
|
||||
memcpy(&priv->std, &tda18271c1_std_map,
|
||||
sizeof(struct tda18271_std_map));
|
||||
priv->std = tda18271c1_std_map;
|
||||
break;
|
||||
case TDA18271HDC2:
|
||||
priv->maps = &tda18271c2_map_layout;
|
||||
memcpy(&priv->std, &tda18271c2_std_map,
|
||||
sizeof(struct tda18271_std_map));
|
||||
priv->std = tda18271c2_std_map;
|
||||
break;
|
||||
default:
|
||||
ret = -EINVAL;
|
||||
|
|
Loading…
Reference in a new issue