mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 00:20:32 +00:00
firmware: vpd: do not leave freed section attributes to the list
We should only add section attribute to the list of section attributes
if we successfully created corresponding sysfs attribute.
Fixes: 049a59db34
("firmware: Google VPD sysfs driver")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
08332893e3
commit
7f53de2069
1 changed files with 1 additions and 1 deletions
|
@ -136,12 +136,12 @@ static int vpd_section_attrib_add(const u8 *key, s32 key_len,
|
||||||
info->value = value;
|
info->value = value;
|
||||||
|
|
||||||
INIT_LIST_HEAD(&info->list);
|
INIT_LIST_HEAD(&info->list);
|
||||||
list_add_tail(&info->list, &sec->attribs);
|
|
||||||
|
|
||||||
ret = sysfs_create_bin_file(sec->kobj, &info->bin_attr);
|
ret = sysfs_create_bin_file(sec->kobj, &info->bin_attr);
|
||||||
if (ret)
|
if (ret)
|
||||||
goto free_info_key;
|
goto free_info_key;
|
||||||
|
|
||||||
|
list_add_tail(&info->list, &sec->attribs);
|
||||||
return 0;
|
return 0;
|
||||||
|
|
||||||
free_info_key:
|
free_info_key:
|
||||||
|
|
Loading…
Reference in a new issue