mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-04 16:15:11 +00:00
Code Issues Releases Wiki Activity

scsi: qedf: Use DEVICE_ATTR_RO() macro

Browse source 
Use DEVICE_ATTR_RO() macro helper instead of plain DEVICE_ATTR(), which
makes the code a bit shorter and easier to read.

Link: https://lore.kernel.org/r/20210616034419.725-3-thunder.leizhen@huawei.com
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Zhen Lei 2021-06-16 11:44:17 +08:00 committed by Martin K. Petersen
parent ffa636470a
commit 80068f8228
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/scsi/qedf/qedf_attr.c
View file

@ -24,9 +24,8 @@ static struct qedf_ctx *qedf_get_base_qedf(struct qedf_ctx *qedf)
return lport_priv(base_lport); return lport_priv(base_lport);
} }
static ssize_t static ssize_t fcoe_mac_show(struct device *dev,
qedf_fcoe_mac_show(struct device *dev, struct device_attribute *attr, char *buf)
struct device_attribute *attr, char *buf)
{ {
struct fc_lport *lport = shost_priv(class_to_shost(dev)); struct fc_lport *lport = shost_priv(class_to_shost(dev));
u32 port_id; u32 port_id;
@ -42,9 +41,8 @@ qedf_fcoe_mac_show(struct device *dev,
return scnprintf(buf, PAGE_SIZE, "%pM\n", fcoe_mac); return scnprintf(buf, PAGE_SIZE, "%pM\n", fcoe_mac);
} }
static ssize_t static ssize_t fka_period_show(struct device *dev,
qedf_fka_period_show(struct device *dev, struct device_attribute *attr, char *buf)
struct device_attribute *attr, char *buf)
{ {
struct fc_lport *lport = shost_priv(class_to_shost(dev)); struct fc_lport *lport = shost_priv(class_to_shost(dev));
struct qedf_ctx *qedf = lport_priv(lport); struct qedf_ctx *qedf = lport_priv(lport);
@ -59,8 +57,8 @@ qedf_fka_period_show(struct device *dev,
return scnprintf(buf, PAGE_SIZE, "%d\n", fka_period); return scnprintf(buf, PAGE_SIZE, "%d\n", fka_period);
} }
static DEVICE_ATTR(fcoe_mac, S_IRUGO, qedf_fcoe_mac_show, NULL); static DEVICE_ATTR_RO(fcoe_mac);
static DEVICE_ATTR(fka_period, S_IRUGO, qedf_fka_period_show, NULL); static DEVICE_ATTR_RO(fka_period);
struct device_attribute *qedf_host_attrs[] = { struct device_attribute *qedf_host_attrs[] = {
&dev_attr_fcoe_mac, &dev_attr_fcoe_mac,