mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
gpio: winbond: Fix error code in winbond_gpio_get()
[ Upstream commit9ca766eaea
] This error path returns 1, but it should instead propagate the negative error code from winbond_sio_enter(). Fixes:a0d6500941
("gpio: winbond: Add driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
9222672fa6
commit
8047734ed1
1 changed files with 4 additions and 3 deletions
|
@ -385,12 +385,13 @@ static int winbond_gpio_get(struct gpio_chip *gc, unsigned int offset)
|
|||
unsigned long *base = gpiochip_get_data(gc);
|
||||
const struct winbond_gpio_info *info;
|
||||
bool val;
|
||||
int ret;
|
||||
|
||||
winbond_gpio_get_info(&offset, &info);
|
||||
|
||||
val = winbond_sio_enter(*base);
|
||||
if (val)
|
||||
return val;
|
||||
ret = winbond_sio_enter(*base);
|
||||
if (ret)
|
||||
return ret;
|
||||
|
||||
winbond_sio_select_logical(*base, info->dev);
|
||||
|
||||
|
|
Loading…
Reference in a new issue