mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
habanalabs: return -EFAULT on copy_to_user error
If copy_to_user failed in info ioctl, we always return -EFAULT so the user will know there was an error. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Oded Gabbay <ogabbay@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
49d2a8af97
commit
804d514d79
1 changed files with 1 additions and 3 deletions
|
@ -118,7 +118,6 @@ static int hw_events_info(struct hl_device *hdev, bool aggregate,
|
|||
|
||||
static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
|
||||
{
|
||||
int rc;
|
||||
u32 max_size = args->return_size;
|
||||
u64 events_mask;
|
||||
void __user *out = (void __user *) (uintptr_t) args->return_pointer;
|
||||
|
@ -131,8 +130,7 @@ static int events_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
|
|||
hpriv->notifier_event.events_mask = 0;
|
||||
mutex_unlock(&hpriv->notifier_event.lock);
|
||||
|
||||
rc = copy_to_user(out, &events_mask, sizeof(u64));
|
||||
return rc;
|
||||
return copy_to_user(out, &events_mask, sizeof(u64)) ? -EFAULT : 0;
|
||||
}
|
||||
|
||||
static int dram_usage_info(struct hl_fpriv *hpriv, struct hl_info_args *args)
|
||||
|
|
Loading…
Reference in a new issue