mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-26 04:16:39 +00:00
vdpa_sim: reset must not run
[ Upstream commit9588e7fc51
] vdpasim_do_reset sets running to true, which is wrong, as it allows vdpasim_kick_vq to post work requests before the device has been configured. To fix, do not set running until VIRTIO_CONFIG_S_DRIVER_OK is set. Fixes:0c89e2a3a9
("vdpa_sim: Implement suspend vdpa op") Signed-off-by: Steve Sistare <steven.sistare@oracle.com> Reviewed-by: Eugenio Pérez <eperezma@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Message-Id: <1707517807-137331-1-git-send-email-steven.sistare@oracle.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1d830032bc
commit
80fc9b9c62
1 changed files with 2 additions and 1 deletions
|
@ -120,7 +120,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim)
|
|||
for (i = 0; i < vdpasim->dev_attr.nas; i++)
|
||||
vhost_iotlb_reset(&vdpasim->iommu[i]);
|
||||
|
||||
vdpasim->running = true;
|
||||
vdpasim->running = false;
|
||||
spin_unlock(&vdpasim->iommu_lock);
|
||||
|
||||
vdpasim->features = 0;
|
||||
|
@ -513,6 +513,7 @@ static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status)
|
|||
|
||||
spin_lock(&vdpasim->lock);
|
||||
vdpasim->status = status;
|
||||
vdpasim->running = (status & VIRTIO_CONFIG_S_DRIVER_OK) != 0;
|
||||
spin_unlock(&vdpasim->lock);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue