mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 22:54:01 +00:00
ethtool: reduce stack usage with clang
commit 3499e87ea0
upstream.
clang inlines the dev_ethtool() more aggressively than gcc does, leading
to a larger amount of used stack space:
net/core/ethtool.c:2536:24: error: stack frame size of 1216 bytes in function 'dev_ethtool' [-Werror,-Wframe-larger-than=]
Marking the sub-functions that require the most stack space as
noinline_for_stack gives us reasonable behavior on all compilers.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Miles Chen <miles.chen@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
30db8e400c
commit
81f7503fb4
1 changed files with 9 additions and 7 deletions
|
@ -2413,9 +2413,10 @@ static int ethtool_set_tunable(struct net_device *dev, void __user *useraddr)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int ethtool_get_per_queue_coalesce(struct net_device *dev,
|
||||
void __user *useraddr,
|
||||
struct ethtool_per_queue_op *per_queue_opt)
|
||||
static noinline_for_stack int
|
||||
ethtool_get_per_queue_coalesce(struct net_device *dev,
|
||||
void __user *useraddr,
|
||||
struct ethtool_per_queue_op *per_queue_opt)
|
||||
{
|
||||
u32 bit;
|
||||
int ret;
|
||||
|
@ -2443,9 +2444,10 @@ static int ethtool_get_per_queue_coalesce(struct net_device *dev,
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int ethtool_set_per_queue_coalesce(struct net_device *dev,
|
||||
void __user *useraddr,
|
||||
struct ethtool_per_queue_op *per_queue_opt)
|
||||
static noinline_for_stack int
|
||||
ethtool_set_per_queue_coalesce(struct net_device *dev,
|
||||
void __user *useraddr,
|
||||
struct ethtool_per_queue_op *per_queue_opt)
|
||||
{
|
||||
u32 bit;
|
||||
int i, ret = 0;
|
||||
|
@ -2499,7 +2501,7 @@ static int ethtool_set_per_queue_coalesce(struct net_device *dev,
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int ethtool_set_per_queue(struct net_device *dev,
|
||||
static int noinline_for_stack ethtool_set_per_queue(struct net_device *dev,
|
||||
void __user *useraddr, u32 sub_cmd)
|
||||
{
|
||||
struct ethtool_per_queue_op per_queue_opt;
|
||||
|
|
Loading…
Reference in a new issue