greybus: fw-core: destroy connections on error

In one of the error cases we aren't destroying the connections created
earlier. Fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2016-05-19 18:27:25 +05:30 committed by Greg Kroah-Hartman
parent 4aea5a15ad
commit 825f79ae76
1 changed files with 1 additions and 2 deletions

View File

@ -139,7 +139,7 @@ static int gb_fw_core_probe(struct gb_bundle *bundle,
dev_err(&bundle->dev, "invalid protocol id (0x%02x)\n",
protocol_id);
ret = -EINVAL;
goto err_free_fw_core;
goto err_destroy_connections;
}
}
@ -187,7 +187,6 @@ err_destroy_connections:
gb_connection_destroy(fw_core->mgmt_connection);
gb_connection_destroy(fw_core->spi_connection);
gb_connection_destroy(fw_core->download_connection);
err_free_fw_core:
kfree(fw_core);
return ret;