mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 07:38:10 +00:00
mmc: sdio: Tidy error path in mmc_attach_sdio()
The error path deletes the device by calling mmc_sdio_remove() which must be called without the host claimed. Simplify the error path so it does just that and add a comment about why we don't disable runtime PM. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
parent
bc55dcd822
commit
82e7edc216
1 changed files with 6 additions and 7 deletions
|
@ -1159,15 +1159,14 @@ int mmc_attach_sdio(struct mmc_host *host)
|
|||
return 0;
|
||||
|
||||
|
||||
remove_added:
|
||||
/* Remove without lock if the device has been added. */
|
||||
mmc_sdio_remove(host);
|
||||
mmc_claim_host(host);
|
||||
remove:
|
||||
/* And with lock if it hasn't been added. */
|
||||
mmc_release_host(host);
|
||||
if (host->card)
|
||||
mmc_sdio_remove(host);
|
||||
remove_added:
|
||||
/*
|
||||
* The devices are being deleted so it is not necessary to disable
|
||||
* runtime PM.
|
||||
*/
|
||||
mmc_sdio_remove(host);
|
||||
mmc_claim_host(host);
|
||||
err:
|
||||
mmc_detach_bus(host);
|
||||
|
|
Loading…
Reference in a new issue