mirrors
/
linux-stable
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
1
0
Fork 0
Code Issues Releases Wiki Activity

peci: Constify struct peci_controller_ops 

As with most ops structs, we never modify it at runtime, and keeping
function pointers in read-only memory is generally a good thing
security-wise.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Link: https://lore.kernel.org/r/20230327224315.11135-1-zev@bewilderbeest.net
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Signed-off-by: Iwona Winiarska <iwona.winiarska@intel.com>
Link: https://lore.kernel.org/r/20230623142805.577612-1-iwona.winiarska@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Zev Weiss 2023-06-23 16:28:05 +02:00 committed by Greg Kroah-Hartman
parent a436194d0e
commit 8306d6f35d
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/peci/controller/peci-aspeed.c
View File

@ -468,7 +468,7 @@ static void aspeed_peci_property_setup(struct aspeed_peci *priv)
ASPEED_PECI_CMD_TIMEOUT_MS_DEFAULT, &priv->cmd_timeout_ms);
}
static struct peci_controller_ops aspeed_ops = {
static const struct peci_controller_ops aspeed_ops = {
.xfer = aspeed_peci_xfer,
};

4
drivers/peci/core.c
View File

@ -44,7 +44,7 @@ int peci_controller_scan_devices(struct peci_controller *controller)
}
static struct peci_controller *peci_controller_alloc(struct device *dev,
struct peci_controller_ops *ops)
const struct peci_controller_ops *ops)
{
struct peci_controller *controller;
int ret;
@ -113,7 +113,7 @@ static void unregister_controller(void *_controller)
* Return: Pointer to the newly allocated controller or ERR_PTR() in case of failure.
*/
struct peci_controller *devm_peci_controller_add(struct device *dev,
struct peci_controller_ops *ops)
const struct peci_controller_ops *ops)
{
struct peci_controller *controller;
int ret;

4
include/linux/peci.h
View File

@ -42,13 +42,13 @@ struct peci_controller_ops {
*/
struct peci_controller {
struct device dev;
struct peci_controller_ops *ops;
const struct peci_controller_ops *ops;
struct mutex bus_lock; /* held for the duration of xfer */
u8 id;
};
struct peci_controller *devm_peci_controller_add(struct device *parent,
struct peci_controller_ops *ops);
const struct peci_controller_ops *ops);
static inline struct peci_controller *to_peci_controller(void *d)
{