mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 07:38:10 +00:00
Code Issues Releases Wiki Activity

[media] USB: Deletion of unnecessary checks before three function calls

Browse source 
GIT_AUTHOR_DATE=1416486805
The functions pvr2_hdw_destroy(), rc_unregister_device() and vfree() perform
also input parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2014-11-20 09:26:36 -03:00 committed by Mauro Carvalho Chehab
parent 332b295d10
commit 83f56f7cbd
4 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/media/usb/au0828/au0828-input.c
View file

@ -363,8 +363,7 @@ void au0828_rc_unregister(struct au0828_dev *dev)
if (!ir)
return;
if (ir->rc)
rc_unregister_device(ir->rc);
rc_unregister_device(ir->rc);
/* done */
kfree(ir);

3
drivers/media/usb/em28xx/em28xx-input.c
View file

@ -841,8 +841,7 @@ static int em28xx_ir_fini(struct em28xx *dev)
if (!ir)
goto ref_put;
if (ir->rc)
rc_unregister_device(ir->rc);
rc_unregister_device(ir->rc);
kfree(ir->i2c_client);

2
drivers/media/usb/pvrusb2/pvrusb2-context.c
View file

@ -80,7 +80,7 @@ static void pvr2_context_set_notify(struct pvr2_context *mp, int fl)
static void pvr2_context_destroy(struct pvr2_context *mp)
{
pvr2_trace(PVR2_TRACE_CTXT,"pvr2_context %p (destroy)",mp);
if (mp->hdw) pvr2_hdw_destroy(mp->hdw);
pvr2_hdw_destroy(mp->hdw);
pvr2_context_set_notify(mp, 0);
mutex_lock(&pvr2_context_mutex);
if (mp->exist_next) {

3
drivers/media/usb/s2255/s2255drv.c
View file

@ -1974,8 +1974,7 @@ static int s2255_release_sys_buffers(struct s2255_vc *vc)
{
unsigned long i;
for (i = 0; i < SYS_FRAMES; i++) {
if (vc->buffer.frame[i].lpvbits)
vfree(vc->buffer.frame[i].lpvbits);
vfree(vc->buffer.frame[i].lpvbits);
vc->buffer.frame[i].lpvbits = NULL;
}
return 0;