mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 15:20:41 +00:00
net/smc: correct settings of RMB window update limit
[ Upstream commit 6bf536eb5c
]
rmbe_update_limit is used to limit announcing receive
window updating too frequently. RFC7609 request a minimal
increase in the window size of 10% of the receive buffer
space. But current implementation used:
min_t(int, rmbe_size / 10, SOCK_MIN_SNDBUF / 2)
and SOCK_MIN_SNDBUF / 2 == 2304 Bytes, which is almost
always less then 10% of the receive buffer space.
This causes the receiver always sending CDC message to
update its consumer cursor when it consumes more then 2K
of data. And as a result, we may encounter something like
"TCP silly window syndrome" when sending 2.5~8K message.
This patch fixes this using max(rmbe_size / 10, SOCK_MIN_SNDBUF / 2).
With this patch and SMC autocorking enabled, qperf 2K/4K/8K
tcp_bw test shows 45%/75%/40% increase in throughput respectively.
Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
273a2e62e5
commit
841304d177
1 changed files with 1 additions and 1 deletions
|
@ -499,7 +499,7 @@ struct smc_buf_desc *smc_buf_get_slot(struct smc_link_group *lgr,
|
||||||
*/
|
*/
|
||||||
static inline int smc_rmb_wnd_update_limit(int rmbe_size)
|
static inline int smc_rmb_wnd_update_limit(int rmbe_size)
|
||||||
{
|
{
|
||||||
return min_t(int, rmbe_size / 10, SOCK_MIN_SNDBUF / 2);
|
return max_t(int, rmbe_size / 10, SOCK_MIN_SNDBUF / 2);
|
||||||
}
|
}
|
||||||
|
|
||||||
static struct smc_buf_desc *smc_new_buf_create(struct smc_link_group *lgr,
|
static struct smc_buf_desc *smc_new_buf_create(struct smc_link_group *lgr,
|
||||||
|
|
Loading…
Reference in a new issue