mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-28 07:13:34 +00:00
media: cec: Respond to unregistered initiators, when applicable
Running CEC 1.4 compliance test we get the following error on test 11.1.6.2: "ERROR: The DUT did not broadcast a <Report Physical Address> message to the unregistered device." Fix this by letting GIVE_PHYSICAL_ADDR message respond to unregistered device. Also, GIVE_DEVICE_VENDOR_ID and GIVE_FEATURES fall in the same category so, respond also to these messages. With this fix we pass CEC 1.4 official compliance. Signed-off-by: Jose Abreu <joabreu@synopsys.com> Cc: Joao Pinto <jpinto@synopsys.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Cc: <stable@vger.kernel.org> # for v4.10 and up Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
e949f61461
commit
845d6524d6
1 changed files with 10 additions and 3 deletions
|
@ -1794,12 +1794,19 @@ static int cec_receive_notify(struct cec_adapter *adap, struct cec_msg *msg,
|
||||||
*/
|
*/
|
||||||
switch (msg->msg[1]) {
|
switch (msg->msg[1]) {
|
||||||
case CEC_MSG_GET_CEC_VERSION:
|
case CEC_MSG_GET_CEC_VERSION:
|
||||||
case CEC_MSG_GIVE_DEVICE_VENDOR_ID:
|
|
||||||
case CEC_MSG_ABORT:
|
case CEC_MSG_ABORT:
|
||||||
case CEC_MSG_GIVE_DEVICE_POWER_STATUS:
|
case CEC_MSG_GIVE_DEVICE_POWER_STATUS:
|
||||||
case CEC_MSG_GIVE_PHYSICAL_ADDR:
|
|
||||||
case CEC_MSG_GIVE_OSD_NAME:
|
case CEC_MSG_GIVE_OSD_NAME:
|
||||||
|
/*
|
||||||
|
* These messages reply with a directed message, so ignore if
|
||||||
|
* the initiator is Unregistered.
|
||||||
|
*/
|
||||||
|
if (!adap->passthrough && from_unregistered)
|
||||||
|
return 0;
|
||||||
|
/* Fall through */
|
||||||
|
case CEC_MSG_GIVE_DEVICE_VENDOR_ID:
|
||||||
case CEC_MSG_GIVE_FEATURES:
|
case CEC_MSG_GIVE_FEATURES:
|
||||||
|
case CEC_MSG_GIVE_PHYSICAL_ADDR:
|
||||||
/*
|
/*
|
||||||
* Skip processing these messages if the passthrough mode
|
* Skip processing these messages if the passthrough mode
|
||||||
* is on.
|
* is on.
|
||||||
|
@ -1807,7 +1814,7 @@ static int cec_receive_notify(struct cec_adapter *adap, struct cec_msg *msg,
|
||||||
if (adap->passthrough)
|
if (adap->passthrough)
|
||||||
goto skip_processing;
|
goto skip_processing;
|
||||||
/* Ignore if addressing is wrong */
|
/* Ignore if addressing is wrong */
|
||||||
if (is_broadcast || from_unregistered)
|
if (is_broadcast)
|
||||||
return 0;
|
return 0;
|
||||||
break;
|
break;
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue