mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-22 17:01:14 +00:00
net: dsa: realtek: do not assert reset on remove
[ Upstream commit 4f580e9ace
]
The necessity of asserting the reset on removal was previously
questioned, as DSA's own cleanup methods should suffice to prevent
traffic leakage[1].
When a driver has subdrivers controlled by devres, they will be
unregistered after the main driver's .remove is executed. If it asserts
a reset, the subdrivers will be unable to communicate with the hardware
during their cleanup. For LEDs, this means that they will fail to turn
off, resulting in a timeout error.
[1] https://lore.kernel.org/r/20240123215606.26716-9-luizluca@gmail.com/
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
b12fb93e18
commit
846c736522
1 changed files with 2 additions and 5 deletions
|
@ -290,16 +290,13 @@ EXPORT_SYMBOL_NS_GPL(rtl83xx_shutdown, REALTEK_DSA);
|
||||||
* rtl83xx_remove() - Cleanup a realtek switch driver
|
* rtl83xx_remove() - Cleanup a realtek switch driver
|
||||||
* @priv: realtek_priv pointer
|
* @priv: realtek_priv pointer
|
||||||
*
|
*
|
||||||
* If a method is provided, this function asserts the hard reset of the switch
|
* Placehold for common cleanup procedures.
|
||||||
* in order to avoid leaking traffic when the driver is gone.
|
|
||||||
*
|
*
|
||||||
* Context: Might sleep if priv->gdev->chip->can_sleep.
|
* Context: Any
|
||||||
* Return: nothing
|
* Return: nothing
|
||||||
*/
|
*/
|
||||||
void rtl83xx_remove(struct realtek_priv *priv)
|
void rtl83xx_remove(struct realtek_priv *priv)
|
||||||
{
|
{
|
||||||
/* leave the device reset asserted */
|
|
||||||
rtl83xx_reset_assert(priv);
|
|
||||||
}
|
}
|
||||||
EXPORT_SYMBOL_NS_GPL(rtl83xx_remove, REALTEK_DSA);
|
EXPORT_SYMBOL_NS_GPL(rtl83xx_remove, REALTEK_DSA);
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue