mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
scsi: be2iscsi: set errno on error path
Variable ret is reset in the loop, and its value will be 0 during the second and after repeat of the loop. If pci_alloc_consistent() returns a NULL pointer then, it will leaves with return value 0. 0 means no error, which is contrary to the fact. This patches fixes the bug, explicitly assigning "-ENOMEM" to return variable ret on the path that the call to pci_alloc_consistent() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188951 Signed-off-by: Pan Bian <bianpan2016@163.com> Reviewed-by: Jitendra Bhivare <Jitendra.bhivare@broadcom.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
parent
29b3325275
commit
84a261ff76
1 changed files with 3 additions and 1 deletions
|
@ -3049,8 +3049,10 @@ static int beiscsi_create_eqs(struct beiscsi_hba *phba,
|
||||||
eq_vaddress = pci_alloc_consistent(phba->pcidev,
|
eq_vaddress = pci_alloc_consistent(phba->pcidev,
|
||||||
num_eq_pages * PAGE_SIZE,
|
num_eq_pages * PAGE_SIZE,
|
||||||
&paddr);
|
&paddr);
|
||||||
if (!eq_vaddress)
|
if (!eq_vaddress) {
|
||||||
|
ret = -ENOMEM;
|
||||||
goto create_eq_error;
|
goto create_eq_error;
|
||||||
|
}
|
||||||
|
|
||||||
mem->va = eq_vaddress;
|
mem->va = eq_vaddress;
|
||||||
ret = be_fill_queue(eq, phba->params.num_eq_entries,
|
ret = be_fill_queue(eq, phba->params.num_eq_entries,
|
||||||
|
|
Loading…
Reference in a new issue