mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 06:10:56 +00:00
bonding: handle link transition from FAIL to UP correctly
[ Upstream commitfb9eb899a6
] When link transitions from LINK_FAIL to LINK_UP, the commit phase is not called. This leads to an erroneous state causing slave-link state to get stuck in "going down" state while its speed and duplex are perfectly fine. This issue is a side-effect of splitting link-set into propose and commit phases introduced byde77ecd4ef
("bonding: improve link-status update in mii-monitoring") This patch fixes these issues by calling commit phase whenever link state change is proposed. Fixes:de77ecd4ef
("bonding: improve link-status update in mii-monitoring") Signed-off-by: Mahesh Bandewar <maheshb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <alexander.levin@microsoft.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
09604c91cb
commit
86138a4972
1 changed files with 2 additions and 1 deletions
|
@ -2067,6 +2067,7 @@ static int bond_miimon_inspect(struct bonding *bond)
|
||||||
(bond->params.downdelay - slave->delay) *
|
(bond->params.downdelay - slave->delay) *
|
||||||
bond->params.miimon,
|
bond->params.miimon,
|
||||||
slave->dev->name);
|
slave->dev->name);
|
||||||
|
commit++;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -2104,7 +2105,7 @@ static int bond_miimon_inspect(struct bonding *bond)
|
||||||
(bond->params.updelay - slave->delay) *
|
(bond->params.updelay - slave->delay) *
|
||||||
bond->params.miimon,
|
bond->params.miimon,
|
||||||
slave->dev->name);
|
slave->dev->name);
|
||||||
|
commit++;
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue