mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
spi: spi-topcliff-pch: Fix potential double free in pch_spi_process_messages()
[ Upstream commit 026a1dc1af
]
pch_spi_set_tx() frees data->pkt_tx_buff on failure of kzalloc() for
data->pkt_rx_buff, but its caller, pch_spi_process_messages(), will
free data->pkt_tx_buff again. Set data->pkt_tx_buff to NULL after
kfree() to avoid double free.
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1620284888-65215-1-git-send-email-f.fangjian@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
ffd424a94a
commit
880ec021ed
1 changed files with 3 additions and 1 deletions
|
@ -584,8 +584,10 @@ static void pch_spi_set_tx(struct pch_spi_data *data, int *bpw)
|
|||
data->pkt_tx_buff = kzalloc(size, GFP_KERNEL);
|
||||
if (data->pkt_tx_buff != NULL) {
|
||||
data->pkt_rx_buff = kzalloc(size, GFP_KERNEL);
|
||||
if (!data->pkt_rx_buff)
|
||||
if (!data->pkt_rx_buff) {
|
||||
kfree(data->pkt_tx_buff);
|
||||
data->pkt_tx_buff = NULL;
|
||||
}
|
||||
}
|
||||
|
||||
if (!data->pkt_rx_buff) {
|
||||
|
|
Loading…
Reference in a new issue