mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
tipc: use destination length for copy string
commit 29e270fc32
upstream.
Got below warning with gcc 8.2 compiler.
net/tipc/topsrv.c: In function ‘tipc_topsrv_start’:
net/tipc/topsrv.c:660:2: warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
strncpy(srv->name, name, strlen(name) + 1);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/tipc/topsrv.c:660:27: note: length computed here
strncpy(srv->name, name, strlen(name) + 1);
^~~~~~~~~~~~
So change it to correct length and use strscpy.
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
02dc68829e
commit
88b58409f8
1 changed files with 1 additions and 1 deletions
|
@ -375,7 +375,7 @@ int tipc_topsrv_start(struct net *net)
|
|||
topsrv->tipc_conn_new = tipc_subscrb_connect_cb;
|
||||
topsrv->tipc_conn_release = tipc_subscrb_release_cb;
|
||||
|
||||
strncpy(topsrv->name, name, strlen(name) + 1);
|
||||
strscpy(topsrv->name, name, sizeof(topsrv->name));
|
||||
tn->topsrv = topsrv;
|
||||
atomic_set(&tn->subscription_count, 0);
|
||||
|
||||
|
|
Loading…
Reference in a new issue