mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-13 12:06:49 +00:00
crypto: stm32/hash - Fix PM reference leak on stm32-hash.c
[ Upstream commit 1cb3ad7019
]
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
836671775a
commit
8a090d492f
1 changed files with 4 additions and 4 deletions
|
@ -812,7 +812,7 @@ static void stm32_hash_finish_req(struct ahash_request *req, int err)
|
|||
static int stm32_hash_hw_init(struct stm32_hash_dev *hdev,
|
||||
struct stm32_hash_request_ctx *rctx)
|
||||
{
|
||||
pm_runtime_get_sync(hdev->dev);
|
||||
pm_runtime_resume_and_get(hdev->dev);
|
||||
|
||||
if (!(HASH_FLAGS_INIT & hdev->flags)) {
|
||||
stm32_hash_write(hdev, HASH_CR, HASH_CR_INIT);
|
||||
|
@ -961,7 +961,7 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
|
|||
u32 *preg;
|
||||
unsigned int i;
|
||||
|
||||
pm_runtime_get_sync(hdev->dev);
|
||||
pm_runtime_resume_and_get(hdev->dev);
|
||||
|
||||
while ((stm32_hash_read(hdev, HASH_SR) & HASH_SR_BUSY))
|
||||
cpu_relax();
|
||||
|
@ -999,7 +999,7 @@ static int stm32_hash_import(struct ahash_request *req, const void *in)
|
|||
|
||||
preg = rctx->hw_context;
|
||||
|
||||
pm_runtime_get_sync(hdev->dev);
|
||||
pm_runtime_resume_and_get(hdev->dev);
|
||||
|
||||
stm32_hash_write(hdev, HASH_IMR, *preg++);
|
||||
stm32_hash_write(hdev, HASH_STR, *preg++);
|
||||
|
@ -1565,7 +1565,7 @@ static int stm32_hash_remove(struct platform_device *pdev)
|
|||
if (!hdev)
|
||||
return -ENODEV;
|
||||
|
||||
ret = pm_runtime_get_sync(hdev->dev);
|
||||
ret = pm_runtime_resume_and_get(hdev->dev);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
|
||||
|
|
Loading…
Reference in a new issue