mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 10:49:33 +00:00
net: Xilinx: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
4e4804be4e
commit
8a0a1f840f
2 changed files with 3 additions and 0 deletions
|
@ -1043,6 +1043,7 @@ static int temac_of_probe(struct platform_device *op)
|
|||
lp->regs = of_iomap(op->dev.of_node, 0);
|
||||
if (!lp->regs) {
|
||||
dev_err(&op->dev, "could not map temac regs.\n");
|
||||
rc = -ENOMEM;
|
||||
goto nodev;
|
||||
}
|
||||
|
||||
|
@ -1062,6 +1063,7 @@ static int temac_of_probe(struct platform_device *op)
|
|||
np = of_parse_phandle(op->dev.of_node, "llink-connected", 0);
|
||||
if (!np) {
|
||||
dev_err(&op->dev, "could not find DMA node\n");
|
||||
rc = -ENODEV;
|
||||
goto err_iounmap;
|
||||
}
|
||||
|
||||
|
|
|
@ -1109,6 +1109,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
|
|||
res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
|
||||
if (!res) {
|
||||
dev_err(dev, "no IRQ found\n");
|
||||
rc = -ENXIO;
|
||||
goto error;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue