mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
[media] cx25840: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Andy Walls <awalls@md.metrocast.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
parent
d486b94b26
commit
8ba6220fe3
1 changed files with 2 additions and 4 deletions
|
@ -1251,13 +1251,11 @@ int cx25840_ir_probe(struct v4l2_subdev *sd)
|
|||
cx25840_write4(ir_state->c, CX25840_IR_IRQEN_REG, 0);
|
||||
|
||||
mutex_init(&ir_state->rx_params_lock);
|
||||
memcpy(&default_params, &default_rx_params,
|
||||
sizeof(struct v4l2_subdev_ir_parameters));
|
||||
default_params = default_rx_params;
|
||||
v4l2_subdev_call(sd, ir, rx_s_parameters, &default_params);
|
||||
|
||||
mutex_init(&ir_state->tx_params_lock);
|
||||
memcpy(&default_params, &default_tx_params,
|
||||
sizeof(struct v4l2_subdev_ir_parameters));
|
||||
default_params = default_tx_params;
|
||||
v4l2_subdev_call(sd, ir, tx_s_parameters, &default_params);
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue