mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
staging: gigaset: add endpoint-type sanity check
commit ed9ed5a89a
upstream.
Add missing endpoint-type sanity checks to probe.
This specifically prevents a warning in USB core on URB submission when
fuzzing USB descriptors.
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20191202085610.12719-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
56a6f72434
commit
8c4d935cc4
1 changed files with 12 additions and 0 deletions
|
@ -708,6 +708,12 @@ static int gigaset_probe(struct usb_interface *interface,
|
|||
|
||||
endpoint = &hostif->endpoint[0].desc;
|
||||
|
||||
if (!usb_endpoint_is_bulk_out(endpoint)) {
|
||||
dev_err(&interface->dev, "missing bulk-out endpoint\n");
|
||||
retval = -ENODEV;
|
||||
goto error;
|
||||
}
|
||||
|
||||
buffer_size = le16_to_cpu(endpoint->wMaxPacketSize);
|
||||
ucs->bulk_out_size = buffer_size;
|
||||
ucs->bulk_out_epnum = usb_endpoint_num(endpoint);
|
||||
|
@ -727,6 +733,12 @@ static int gigaset_probe(struct usb_interface *interface,
|
|||
|
||||
endpoint = &hostif->endpoint[1].desc;
|
||||
|
||||
if (!usb_endpoint_is_int_in(endpoint)) {
|
||||
dev_err(&interface->dev, "missing int-in endpoint\n");
|
||||
retval = -ENODEV;
|
||||
goto error;
|
||||
}
|
||||
|
||||
ucs->busy = 0;
|
||||
|
||||
ucs->read_urb = usb_alloc_urb(0, GFP_KERNEL);
|
||||
|
|
Loading…
Reference in a new issue