mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 18:30:06 +00:00
v4l: rcar-fcp: Don't get/put module reference
Direct callers of the FCP API hold a reference to the FCP module due to module linkage, there's no need to take another one manually. Take a reference to the device instead to ensure that it won't disappear behind the caller's back. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Acked-by: Mauro Cavalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
parent
d503a43ac0
commit
8c71a1a318
1 changed files with 2 additions and 9 deletions
|
@ -53,14 +53,7 @@ struct rcar_fcp_device *rcar_fcp_get(const struct device_node *np)
|
|||
if (fcp->dev->of_node != np)
|
||||
continue;
|
||||
|
||||
/*
|
||||
* Make sure the module won't be unloaded behind our back. This
|
||||
* is a poor man's safety net, the module should really not be
|
||||
* unloaded while FCP users can be active.
|
||||
*/
|
||||
if (!try_module_get(fcp->dev->driver->owner))
|
||||
fcp = NULL;
|
||||
|
||||
get_device(fcp->dev);
|
||||
goto done;
|
||||
}
|
||||
|
||||
|
@ -81,7 +74,7 @@ EXPORT_SYMBOL_GPL(rcar_fcp_get);
|
|||
void rcar_fcp_put(struct rcar_fcp_device *fcp)
|
||||
{
|
||||
if (fcp)
|
||||
module_put(fcp->dev->driver->owner);
|
||||
put_device(fcp->dev);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(rcar_fcp_put);
|
||||
|
||||
|
|
Loading…
Reference in a new issue