mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 13:53:33 +00:00
usb: usbip: add missing device lock on tweak configuration cmd
[ Upstream commitd088fabace
] The function documentation of usb_set_configuration says that its callers should hold the device lock. This lock is held for all callsites except tweak_set_configuration_cmd. The code path can be executed for example when attaching a remote USB device. The solution is to surround the call by the device lock. This bug was found using my experimental own-developed static analysis tool, which reported the missing lock on v5.17.2. I manually verified this bug report by doing code review as well. I runtime checked that the required lock is not held. I compiled and runtime tested this on x86_64 with a USB mouse. After applying this patch, my analyser no longer reports this potential bug. Fixes:2c8c981589
("staging: usbip: let client choose device configuration") Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> Signed-off-by: Niels Dossche <dossche.niels@gmail.com> Link: https://lore.kernel.org/r/20220412165055.257113-1-dossche.niels@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
8afb048800
commit
8c78d7b7ce
1 changed files with 2 additions and 0 deletions
|
@ -138,7 +138,9 @@ static int tweak_set_configuration_cmd(struct urb *urb)
|
|||
req = (struct usb_ctrlrequest *) urb->setup_packet;
|
||||
config = le16_to_cpu(req->wValue);
|
||||
|
||||
usb_lock_device(sdev->udev);
|
||||
err = usb_set_configuration(sdev->udev, config);
|
||||
usb_unlock_device(sdev->udev);
|
||||
if (err && err != -ENODEV)
|
||||
dev_err(&sdev->udev->dev, "can't set config #%d, error %d\n",
|
||||
config, err);
|
||||
|
|
Loading…
Reference in a new issue