mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 07:04:24 +00:00
powerpc/eeh: Drop taken reference to driver on eeh_rmv_device
Commit f5c57710dd
("powerpc/eeh: Use
partial hotplug for EEH unaware drivers") introduces eeh_rmv_device,
which may grab a reference to a driver, but not release it.
That prevents a driver from being removed after it has gone through EEH
recovery.
This patch drops the reference if it was taken.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
Acked-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
parent
0215b4aa06
commit
8cc6b6cd87
1 changed files with 6 additions and 2 deletions
|
@ -362,9 +362,13 @@ static void *eeh_rmv_device(void *data, void *userdata)
|
||||||
*/
|
*/
|
||||||
if (!dev || (dev->hdr_type & PCI_HEADER_TYPE_BRIDGE))
|
if (!dev || (dev->hdr_type & PCI_HEADER_TYPE_BRIDGE))
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
driver = eeh_pcid_get(dev);
|
driver = eeh_pcid_get(dev);
|
||||||
if (driver && driver->err_handler)
|
if (driver) {
|
||||||
return NULL;
|
eeh_pcid_put(dev);
|
||||||
|
if (driver->err_handler)
|
||||||
|
return NULL;
|
||||||
|
}
|
||||||
|
|
||||||
/* Remove it from PCI subsystem */
|
/* Remove it from PCI subsystem */
|
||||||
pr_debug("EEH: Removing %s without EEH sensitive driver\n",
|
pr_debug("EEH: Removing %s without EEH sensitive driver\n",
|
||||||
|
|
Loading…
Reference in a new issue