mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 08:08:54 +00:00
USB: gadget: pxa25x_udc: fix memory leak with using debugfs_lookup()
[ Upstream commit 7a038a681b
]
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>
Cc: Robert Jarzmik <robert.jarzmik@free.fr>
Link: https://lore.kernel.org/r/20230202153235.2412790-11-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
72c25eb9ae
commit
8d48a7887d
1 changed files with 1 additions and 1 deletions
|
@ -1340,7 +1340,7 @@ DEFINE_SHOW_ATTRIBUTE(udc_debug);
|
|||
debugfs_create_file(dev->gadget.name, \
|
||||
S_IRUGO, NULL, dev, &udc_debug_fops); \
|
||||
} while (0)
|
||||
#define remove_debug_files(dev) debugfs_remove(debugfs_lookup(dev->gadget.name, NULL))
|
||||
#define remove_debug_files(dev) debugfs_lookup_and_remove(dev->gadget.name, NULL)
|
||||
|
||||
#else /* !CONFIG_USB_GADGET_DEBUG_FILES */
|
||||
|
||||
|
|
Loading…
Reference in a new issue