phy: ti: gmii-sel: check of_get_address() for failure
Smatch complains that if of_get_address() returns NULL, then "size"
isn't initialized. Also it would lead to an Oops.
Fixes: 7f78322cdd
("phy: ti: gmii-sel: retrieve ports number and base offset from dt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Link: https://lore.kernel.org/r/20210914110038.GB11657@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
parent
d8b951abd7
commit
8d55027f4e
|
@ -320,6 +320,8 @@ static int phy_gmii_sel_init_ports(struct phy_gmii_sel_priv *priv)
|
|||
u64 size;
|
||||
|
||||
offset = of_get_address(dev->of_node, 0, &size, NULL);
|
||||
if (!offset)
|
||||
return -EINVAL;
|
||||
priv->num_ports = size / sizeof(u32);
|
||||
if (!priv->num_ports)
|
||||
return -EINVAL;
|
||||
|
|
Loading…
Reference in New Issue