mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
net: sched: fix memory leak in tcindex_partial_destroy_work
[ Upstream commitf5051bcece
] Syzbot reported memory leak in tcindex_set_parms(). The problem was in non-freed perfect hash in tcindex_partial_destroy_work(). In tcindex_set_parms() new tcindex_data is allocated and some fields from old one are copied to new one, but not the perfect hash. Since tcindex_partial_destroy_work() is the destroy function for old tcindex_data, we need to free perfect hash to avoid memory leak. Reported-and-tested-by: syzbot+f0bbb2287b8993d4fa74@syzkaller.appspotmail.com Fixes:331b72922c
("net: sched: RCU cls_tcindex") Signed-off-by: Pavel Skripkin <paskripkin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
f38527f189
commit
8d7924ce85
1 changed files with 4 additions and 1 deletions
|
@ -278,6 +278,8 @@ static int tcindex_filter_result_init(struct tcindex_filter_result *r,
|
||||||
TCA_TCINDEX_POLICE);
|
TCA_TCINDEX_POLICE);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void tcindex_free_perfect_hash(struct tcindex_data *cp);
|
||||||
|
|
||||||
static void tcindex_partial_destroy_work(struct work_struct *work)
|
static void tcindex_partial_destroy_work(struct work_struct *work)
|
||||||
{
|
{
|
||||||
struct tcindex_data *p = container_of(to_rcu_work(work),
|
struct tcindex_data *p = container_of(to_rcu_work(work),
|
||||||
|
@ -285,7 +287,8 @@ static void tcindex_partial_destroy_work(struct work_struct *work)
|
||||||
rwork);
|
rwork);
|
||||||
|
|
||||||
rtnl_lock();
|
rtnl_lock();
|
||||||
kfree(p->perfect);
|
if (p->perfect)
|
||||||
|
tcindex_free_perfect_hash(p);
|
||||||
kfree(p);
|
kfree(p);
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue