mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
vfio: Fix NULL pointer dereference caused by uninitialized group->iommufd
commitd649c34cb9
upstream. group->iommufd is not initialized for the iommufd_ctx_put() [20018.331541] BUG: kernel NULL pointer dereference, address: 0000000000000000 [20018.377508] RIP: 0010:iommufd_ctx_put+0x5/0x10 [iommufd] ... [20018.476483] Call Trace: [20018.479214] <TASK> [20018.481555] vfio_group_fops_unl_ioctl+0x506/0x690 [vfio] [20018.487586] __x64_sys_ioctl+0x6a/0xb0 [20018.491773] ? trace_hardirqs_on+0xc5/0xe0 [20018.496347] do_syscall_64+0x67/0x90 [20018.500340] entry_SYSCALL_64_after_hwframe+0x4b/0xb5 Fixes:9eefba8002
("vfio: Move vfio group specific code into group.c") Cc: stable@vger.kernel.org Signed-off-by: Yan Zhao <yan.y.zhao@intel.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Yi Liu <yi.l.liu@intel.com> Link: https://lore.kernel.org/r/20230222074938.13681-1-yan.y.zhao@intel.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
3e64bb920a
commit
8f24eef598
1 changed files with 1 additions and 1 deletions
|
@ -137,7 +137,7 @@ static int vfio_group_ioctl_set_container(struct vfio_group *group,
|
|||
|
||||
ret = iommufd_vfio_compat_ioas_id(iommufd, &ioas_id);
|
||||
if (ret) {
|
||||
iommufd_ctx_put(group->iommufd);
|
||||
iommufd_ctx_put(iommufd);
|
||||
goto out_unlock;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue