mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-20 01:20:54 +00:00
Code Issues Releases Wiki Activity

qlcnic: prevent ->dcb use-after-free on qlcnic_dcb_enable() failure

Browse source 
[ Upstream commit 13a7c8964a ]

adapter->dcb would get silently freed inside qlcnic_dcb_enable() in
case qlcnic_dcb_attach() would return an error, which always happens
under OOM conditions. This would lead to use-after-free because both
of the existing callers invoke qlcnic_dcb_get_info() on the obtained
pointer, which is potentially freed at that point.

Propagate errors from qlcnic_dcb_enable(), and instead free the dcb
pointer at callsite using qlcnic_dcb_free(). This also removes the now
unused qlcnic_clear_dcb_ops() helper, which was a simple wrapper around
kfree() also causing memory leaks for partially initialized dcb.

Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.

Fixes: 3c44bba1d2 ("qlcnic: Disable DCB operations from SR-IOV VFs")
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Daniil Tatianin 2022-12-22 14:52:28 +03:00 committed by Greg Kroah-Hartman
parent 55ac68b53f
commit 8f97eeb02a
3 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
View file

@ -2525,7 +2525,13 @@ int qlcnic_83xx_init(struct qlcnic_adapter *adapter, int pci_using_dac)
goto disable_mbx_intr;
qlcnic_83xx_clear_function_resources(adapter);
qlcnic_dcb_enable(adapter->dcb);
err = qlcnic_dcb_enable(adapter->dcb);
if (err) {
qlcnic_dcb_free(adapter->dcb);
goto disable_mbx_intr;
}
qlcnic_83xx_initialize_nic(adapter, 1);
qlcnic_dcb_get_info(adapter->dcb);

10
drivers/net/ethernet/qlogic/qlcnic/qlcnic_dcb.h
View file

@ -42,11 +42,6 @@ struct qlcnic_dcb {
unsigned long state;
};
static inline void qlcnic_clear_dcb_ops(struct qlcnic_dcb *dcb)
{
kfree(dcb);
}
static inline int qlcnic_dcb_get_hw_capability(struct qlcnic_dcb *dcb)
{
if (dcb && dcb->ops->get_hw_capability)
@ -113,9 +108,8 @@ static inline void qlcnic_dcb_init_dcbnl_ops(struct qlcnic_dcb *dcb)
dcb->ops->init_dcbnl_ops(dcb);
}
static inline void qlcnic_dcb_enable(struct qlcnic_dcb *dcb)
static inline int qlcnic_dcb_enable(struct qlcnic_dcb *dcb)
{
if (dcb && qlcnic_dcb_attach(dcb))
qlcnic_clear_dcb_ops(dcb);
return dcb ? qlcnic_dcb_attach(dcb) : 0;
}
#endif

8
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
View file

@ -2639,7 +2639,13 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
"Device does not support MSI interrupts\n");
if (qlcnic_82xx_check(adapter)) {
qlcnic_dcb_enable(adapter->dcb);
err = qlcnic_dcb_enable(adapter->dcb);
if (err) {
qlcnic_dcb_free(adapter->dcb);
dev_err(&pdev->dev, "Failed to enable DCB\n");
goto err_out_free_hw;
}
qlcnic_dcb_get_info(adapter->dcb);
err = qlcnic_setup_intr(adapter);