mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 00:39:48 +00:00
ipmi_si: Fix wrong return value in try_smi_init()
On an error exit path, a negative error code should be returned
instead of a positive return value.
Fixes: 90b2d4f15f
("ipmi_si: Remove hacks for adding a dummy platform devices")
Cc: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Message-Id: <20201005145212.84435-1-tianjia.zhang@linux.alibaba.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
This commit is contained in:
parent
c011410d91
commit
8fe7990ced
1 changed files with 1 additions and 1 deletions
|
@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi)
|
||||||
/* Do this early so it's available for logs. */
|
/* Do this early so it's available for logs. */
|
||||||
if (!new_smi->io.dev) {
|
if (!new_smi->io.dev) {
|
||||||
pr_err("IPMI interface added with no device\n");
|
pr_err("IPMI interface added with no device\n");
|
||||||
rv = EIO;
|
rv = -EIO;
|
||||||
goto out_err;
|
goto out_err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue