thermal/drivers/mediatek/lvts_thermal: Return error in case of invalid efuse data

[ Upstream commit 72cacd06e4 ]

This patch prevents from registering thermal entries and letting the
driver misbehave if efuse data is invalid. A device is not properly
calibrated if the golden temperature is zero.

Fixes: f5f633b182 ("thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver")
Signed-off-by: Julien Panis <jpanis@baylibre.com>
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20240604-mtk-thermal-calib-check-v2-1-8f258254051d@baylibre.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Julien Panis 2024-06-04 18:46:58 +02:00 committed by Greg Kroah-Hartman
parent 47a0fe77b6
commit 90d29da114

View file

@ -700,7 +700,11 @@ static int lvts_golden_temp_init(struct device *dev, u32 *value)
gt = (*value) >> 24;
if (gt && gt < LVTS_GOLDEN_TEMP_MAX)
/* A zero value for gt means that device has invalid efuse data */
if (!gt)
return -ENODATA;
if (gt < LVTS_GOLDEN_TEMP_MAX)
golden_temp = gt;
coeff_b = golden_temp * 500 + LVTS_COEFF_B;