mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 21:03:32 +00:00
firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe
commitdd218433f2
upstream. The devm_memremap() function returns error pointers. It never returns NULL. Fix the check. Fixes:7ca5ce8965
("firmware: add Intel Stratix10 service layer driver") Cc: stable@vger.kernel.org Signed-off-by: Wang Ming <machel@vivo.com> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org> Link: https://lore.kernel.org/r/20230727193750.983795-1-dinguyen@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
b6340d4d4e
commit
90f006a065
1 changed files with 1 additions and 1 deletions
|
@ -756,7 +756,7 @@ svc_create_memory_pool(struct platform_device *pdev,
|
|||
paddr = begin;
|
||||
size = end - begin;
|
||||
va = devm_memremap(dev, paddr, size, MEMREMAP_WC);
|
||||
if (!va) {
|
||||
if (IS_ERR(va)) {
|
||||
dev_err(dev, "fail to remap shared memory\n");
|
||||
return ERR_PTR(-EINVAL);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue