mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
NFS: Correct timing for assigning access cache timestamp
[ Upstream commit21fd9e8700
] When the user's login time is newer than the cache's timestamp, the original entry in the RB-tree will be replaced by a new entry. Currently, the timestamp is only set if the entry is not found in the RB-tree, which can cause the timestamp to be undefined when the entry exists. This may result in a significant increase in ACCESS operations if the timestamp is set to zero. Signed-off-by: Chengen Du <chengen.du@canonical.com> Fixes:0eb43812c0
("NFS: Clear the file access cache upon login”) Reviewed-by: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
89ab36bb8b
commit
90f2b0b417
1 changed files with 1 additions and 1 deletions
|
@ -3089,7 +3089,6 @@ static void nfs_access_add_rbtree(struct inode *inode,
|
|||
else
|
||||
goto found;
|
||||
}
|
||||
set->timestamp = ktime_get_ns();
|
||||
rb_link_node(&set->rb_node, parent, p);
|
||||
rb_insert_color(&set->rb_node, root_node);
|
||||
list_add_tail(&set->lru, &nfsi->access_cache_entry_lru);
|
||||
|
@ -3114,6 +3113,7 @@ void nfs_access_add_cache(struct inode *inode, struct nfs_access_entry *set,
|
|||
cache->fsgid = cred->fsgid;
|
||||
cache->group_info = get_group_info(cred->group_info);
|
||||
cache->mask = set->mask;
|
||||
cache->timestamp = ktime_get_ns();
|
||||
|
||||
/* The above field assignments must be visible
|
||||
* before this item appears on the lru. We cannot easily
|
||||
|
|
Loading…
Reference in a new issue