mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
Input: imx_keypad - only set enabled columns to open-drain
In imx_keypad_inhibit(), all 8 columns were set to open-drain, in contrast to the rest of the driver, where only the enabled columns are modified/used. Contrary to the normal expectation, this also affects column I/Os not even mapped via IOMUX to the KPP hardware module but used as a GPIO. Therefore only init enabled columns to open-drain and leave all others with their default reset value of 0, i.e. totem-pole. Signed-off-by: Andreas Pretzsch <apr@cn-eng.de> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
parent
52ad48a0ce
commit
92aab96034
1 changed files with 2 additions and 1 deletions
|
@ -362,7 +362,8 @@ static void imx_keypad_inhibit(struct imx_keypad *keypad)
|
||||||
writew(reg_val, keypad->mmio_base + KPSR);
|
writew(reg_val, keypad->mmio_base + KPSR);
|
||||||
|
|
||||||
/* Colums as open drain and disable all rows */
|
/* Colums as open drain and disable all rows */
|
||||||
writew(0xff00, keypad->mmio_base + KPCR);
|
reg_val = (keypad->cols_en_mask & 0xff) << 8;
|
||||||
|
writew(reg_val, keypad->mmio_base + KPCR);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void imx_keypad_close(struct input_dev *dev)
|
static void imx_keypad_close(struct input_dev *dev)
|
||||||
|
|
Loading…
Reference in a new issue