mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-03 15:47:36 +00:00
Code Issues Releases Wiki Activity

md: raid0: chunk size check in raid0_run

Browse source 
have raid0 check chunk size in run method instead of in md.
This is part of a series moving the checks from common code to
the personalities where they belong.

hardsect is short and chunksize is an int, so it is safe to use %.

Signed-off-by: raziebe@gmail.com
Signed-off-by: NeilBrown <neilb@suse.de>
This commit is contained in:
raz ben yehuda 2009-06-16 17:00:57 +10:00 committed by NeilBrown
parent 46994191ae
commit 92e59b6ba2
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/md/raid0.c
View file

@ -234,6 +234,16 @@ static int create_strip_zones(mddev_t *mddev)
mddev->queue->backing_dev_info.congested_fn = raid0_congested;
mddev->queue->backing_dev_info.congested_data = mddev;
/*
* now since we have the hard sector sizes, we can make sure
* chunk size is a multiple of that sector size
*/
if (mddev->chunk_size % queue_logical_block_size(mddev->queue)) {
printk(KERN_ERR "%s chunk_size of %d not valid\n",
mdname(mddev),
mddev->chunk_size);
goto abort;
}
printk(KERN_INFO "raid0: done.\n");
mddev->private = conf;
return 0;
@ -289,8 +299,9 @@ static int raid0_run(mddev_t *mddev)
{
int ret;
if (mddev->chunk_size == 0) {
printk(KERN_ERR "md/raid0: non-zero chunk size required.\n");
if (mddev->chunk_size == 0 ||
!is_power_of_2(mddev->chunk_size)) {
printk(KERN_ERR "md/raid0: chunk size must be a power of 2.\n");
return -EINVAL;
}
blk_queue_max_sectors(mddev->queue, mddev->chunk_size >> 9);